Closed
Labels
Description
I was thankful to see your reaction to my issue #453, but unfortunately GitPython 2.0.9 has some issues on Python 2.6. GitPython 2.0.8 worked like a charm for us.
The issues are:
- uses of dictionary comprehension in
git/cmd.pyaround line 800 (dict comprehensions were introduced in py27). - use of SkipTest and skipIf from
unittest.caseingit/util.pyand in several test cases (these were added tounittestin py27). Also, the Pythonunittestdocs suggest they be imported fromunittestand not fromunittest.case, but that is minor.
I have fixed those locally and will create a PR for your review.
Activity
hugovk commentedon Mar 12, 2018
PR #541 was merged on 8 Dec 2016. Can this issue be closed?
Whilst on the topic, is Python 2.6 still something you need to support, or might it be time to consider dropping it more fully?
Here's the pip installs for GitPython from PyPI for last month:
Source:
pypinfo --start-date -39 --end-date -12 --percent --pip --markdown GitPython pyversionByron commentedon Mar 17, 2018
@hugovk Thanks a lot for publishing some hard facts about its usage here! I wasn't even aware of download information once again being available.
I think you are providing a strong argument to indeed drop python 2.6 support, the next time we break it. Alternatively, if someone feels strongly about getting rid of it to improve the code climate for example, PRs are always welcome.
As the PR mentioned in this issue was merged, I think it's fair to close this ticket, too.
hugovk commentedon Mar 18, 2018
Yeah, there's quite a lot of interesting stuff you can now get out of PyPI and pypinfo:
https://github.com/ofek/pypinfo/blob/master/README.rst#usage
Here's some examples:
Byron commentedon Mar 18, 2018
Super-interesting indeed! I wonder how these numbers are actually computed (just a rhetorical question really), just because they seem very, very high! Especially since it's just the monthly downloads. Could GitPython really be that popular :D?