Repository navigation
Keep curtsies output without a newline with its prompt - #1061
Open
Hugohong258 wants to merge 2 commits into
Open
Hugohong258 wants to merge 2 commits into
Hugohong258 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1061 +/- ##
==========================================
- Coverage 76.51% 76.50% -0.02%
==========================================
Files 62 61 -1
Lines 8308 8496 +188
==========================================
+ Hits 6357 6500 +143
- Misses 1951 1996 +45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Please rebase on current main to get rid of the urwid related failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
print("Hello!", end=""), pressing Enter movesHello!down to the new prompt. Each subsequent Enter moves it again. The curtsies frontend now keeps pending output with the input line that followed it. Undoing an empty prompt restores the pending output, and session export retains it in order.Fixes #1050.
The rendering regression failed on the unmodified implementation. On WSL Ubuntu with Python 3.14.4,
python -m pytest -q --tb=shortreported 315 passed, 14 skipped, 3 xfailed, and 3 subtests passed. Codespell passed on the changed files. Black 26.10.1 reports the same formatting difference inversion_help_texton the base and the patch. The CI platform and interpreter matrix was not run locally.This patch and its tests were prepared with AI assistance.